Zach Deane-Mayer

Results 138 comments of Zach Deane-Mayer
trafficstars

Awesome, thanks. I'll take a look at the code, and if I can easily implement it on my own, I'll take a stab at it.

`category_encoders.one_hot.OneHotEncoder` has 2 additional features I often use that are not in sklearn.preprocessing.OneHotEncoder: 1. `drop_invariant=True` to drop columns with zero variance (e.g. a categorical feature that is all one level)....

Also, category_encoders has `category_encoders.ordinal.OrdinalEncoder` while sklearn has `sklearn.preprocessing.OrdinalEncoder`. In this case OrdinalEncoder has 3 features missing from sklearn: 1. `drop_invariant=True`. 2. `handle_missing=True`. 3. `handle_unknown=True` to handle encoding for new categories....

Should I make a feature request on sklearn to add `handle_missing` and `handle_unknown` to their cat encoders?

Here's a request to add handle_missing to the OneHotEncoder in sklearn https://github.com/scikit-learn/scikit-learn/issues/11996

I also opened an issue for OrdinalEncoder: https://github.com/scikit-learn/scikit-learn/issues/17123

Similarly multilevel.community does not return a full hierarchy, but would still be useful to visualize as a dendrogram.

Try putting all the parameters in tuneGrid, instead of passing them directly Sent from my iPhone > On Oct 26, 2016, at 11:11 PM, brent-halen [email protected] wrote: > > I'm...

Here's a script that reproduces the error: ``` library(glmnet) library(mda) library(rpart) x

It seems like the problem is the child classes (elnet and mda) that inherit from parent classes (glmnet, fda). Neither package defines S3 methods for the child classes,