git_ops icon indicating copy to clipboard operation
git_ops copied to clipboard

Major version changes should require a flag and/or manual confirmation

Open zachdaniel opened this issue 1 year ago • 4 comments

mix git_ops.release --allow-major and if thats not supplied, it will prompt for confirmation. This would have saved me lots of stress on multiple occasions 😆

zachdaniel avatar Apr 10 '24 11:04 zachdaniel

If this flag is introduced, would --yes still override it? I think it should. CI should release whatever version number the commits' messages tell, IMHO.

marc0s avatar Jul 25 '24 08:07 marc0s

Agreed. --yes should override.

zachdaniel avatar Jul 25 '24 11:07 zachdaniel

I'll try to get a PR for this issue. One question I have is: what's the expected behavior when both --allow-major and --no-major are given?

IMHO, we should error as they're kind of conflicting options.

Another option is to let --allow-major override --no-major and keep going, maybe with a warning log so it doesn't go unnoticed.

marc0s avatar Jul 25 '24 17:07 marc0s

I think they should error if specified together.

zachdaniel avatar Jul 25 '24 22:07 zachdaniel