Zach Daniel
Zach Daniel
Any updates on how we're feeling about this?
In general yes the idea is that the installer lives directly inside the thing being installed. This ensures that it's versioned alongside the thing that is being installed, allowing hex...
> Not very popular yet, but this is not a lot to maintain (and it might become popular). I'm not being defensive I promise, but it depends a bit on...
> I would just really strongly advise to add this as a dependency to Sentry itself ever in the future, but I don't think we would need that. I don't...
I've got a test failing that seems unrelated to my change, but otherwise I've rebased.
Looks like some issues come from building for pre 1.15 versions of Elixir, due to spitfire. This wouldn't cause problems for existing users on older versions of sentry, as igniter...
I'll update the tests not to require phx_new as an optional dependency. That is a utility some projects choose to use, but its not necessary 😄
Alright, fixed. I could also potentially go find a way to make spitfire still compile on Elixir 1.13. It doesn't matter if it doesn't work, its a "bonus" tool that...
Ready for another run 😄
PR feedback/failures should be resolved, last major issue is the 1.13 issue. I'm going to try and make a PR to spitfire that lets it at least compile on 1.13....