h3-pg icon indicating copy to clipboard operation
h3-pg copied to clipboard

Published 20 hours ago • verified publisher icon zachasme

Align SQL naming with DuckDB

Open zachasme opened this issue 6 months ago • 4 comments

It would be nice to align SQL binding function naming across dialects.

See https://github.com/uber/h3/pull/1005#discussion_r2074656959.

This PR alters function names containing lat_lng to latlng through a soft-deprecation warning.

Closes #175

zachasme avatar May 21 '25 13:05 zachasme

@Komzpa if it is not too much to ask, could you test this upgrade on one of your projects? I've tried to make sure existing projects don't break, but only raise a deprecation warning. But I would like to double-check :-)

zachasme avatar May 22 '25 09:05 zachasme

Hi @zachasme, @Komzpa asked me to test this PR. It looks good — will run some checks and report back with the results.

frolui avatar May 22 '25 12:05 frolui

Hi @zachasme, I did some tests and for me everything works as expected. I see only warnings.

frolui avatar May 26 '25 19:05 frolui

That's reassuring, thank you for taking the time to test this :+1: I'll try to fix the last tests and wrap up a release soon

zachasme avatar May 27 '25 07:05 zachasme