yw4z

Results 90 comments of yw4z

thanks for your efforts on this, i will report results This problem also appears on popup windows of toolbar. especially on these places - Emboss > alignment icons - Emboss...

No i didnt changed their resolution to reduce code changes ![Screenshot-20240319054512](https://github.com/SoftFever/OrcaSlicer/assets/28517890/267c9b8c-153f-4731-bd44-1629c71889c3) mostly they have blank 1px line 2 sides I'm adding all required changes in that commit as a to-do...

@Noisyfox changing this line to int fixed issue for toolbar popup icons. they are pixel perfect now :) https://github.com/SoftFever/OrcaSlicer/blob/f3b3e927824339bd76346bbb40b417de51aba31c/src/slic3r/GUI/IconManager.cpp#L376 included this to my UI [commit](https://github.com/SoftFever/OrcaSlicer/pull/4368)

yes also fixed blur on keyboard cheat sheet button

@Noisyfox @SoftFever here is my observations with code changes. i compiled with this changes trying to make icons pixel perfect is unnecessary with scaling imo. i guess only necessary change...

@SoftFever updated code change. yes `!bmps.empty()` is simpler choose for condition ``` if (node->has_warning_icon()) bmps.emplace_back(node->warning_icon_name() == WarningIcon ? m_warning_bmp : m_warning_manifold_bmp); if (node->has_lock()) { if (!bmps.empty()) // ORCA: Add spacing...

First thanks. this one is on my list too. annoys me too much can you test this improvement with this commit https://github.com/SoftFever/OrcaSlicer/pull/5221 I added icons too all tabs on that...

I said check because you said some icons appeared. if there is no additional icons appeared then there is no problem also i suggest convert lines to comments instead of...

@SoftFever tested few time, parameters on unactive tabs not updates when preset changes

@SoftFever whats the downside for that? i guess it will not slowdown parameter change until we got 99+ tabs with full of configs. better then rebuilding whole UI elements