Yuxin Wang comments

Results 36 comments of


                                            Yuxin Wang

Incomplete Nil Pointer Detection in Struct Fields

Thanks for the report! Right, currently the core NilAway does not reason too much about struct fields, especially struct initializations (e.g., creating empty structs or creating empty structs and then...

Support general nonnil->nonnil function contract, i.e., having a single nonnil but any numbers of any, e.g. contract(_,nonnil->nonnil,_)

We have made significant changes to NilAway since this PR was originally created, so I'm closing this PR as it's really hard to rebase the changes onto the current main....

Not catching possible type assertion exceptions?

Hi! Type assertions are not fully handled in NilAway right now, which is why you're seeing the false negative here. I'm keeping this issue open to track the efforts :)

Add support for `errors.As` in trusted functions framework

The weird thing here is that `errors.As` could still result in the result error being `nil`. See https://go.dev/play/p/0aHuuJb2K36: ```go package main import ( "errors" "fmt" "github.com/go-sql-driver/mysql" ) func main() {...

panic on main(67945fb)

Thanks for reporting. I guess there are not many things we can do from NilAway's end but to advise building with Go 1.22 (which we support). Seems to be a...

Internal panic (conflicting position information on upstream object) with latest rules_go

I can confirm this problem is reproduced and it seems to be related to the `x/tools` upgrade (this problem exists since v0.11.1 to the latest version). Currently you can pin...

panic on main(67945fb)

Since Go has recently released 1.23 and we have bumped our minimum supported version to be 1.22, I'm closing this issue :) feel free to reopen if this issue exists...

Internal panic (conflicting position information on upstream object) with latest rules_go

Hi @philipuvarov, we have investigated the issue and the root cause was that the `x/tools` library applied an optimization to not export facts of the transitive dependencies. Instead, it now...

Unchanged files with check annotations

I think this is the github actions' logic that has some heuristics that automatically picks up sentences that start with `error:`. Seeing [one of recent PRs](https://github.com/autobrr/autobrr/pull/1348/files) from your repository it...

Unchanged files with check annotations

Yes, this has to be built (either as a separate formatter within NilAway, or a custom post-process script on your end). Running NilAway with `-json` flag will instruct it to...