Yuvi
Yuvi
The original goal for putting them in the API and doing this in the frontend was to support URL parsing in other frontends, such as jupyterhub-fancy-profiles so they can have...
Thanks for writing all this down - the screenshots are also particularly helpful! Let's go with: > remove validateRegex altogether, leave it to the server-side provider to present errors (i.e....
Ah interesting! I think @jmunroe also ran into this recently. If my understanding is right, the existing code doesn't stream but waits for the entire upstream request to be completed...
Ah damn, I just realized that won't work, because of our `RewriteableResponse` implementation :( That implementation's signature depends on being able to buffer requests, rather than being able to stream...
As for testing, I suggest: 1. Create a simple eventstream emitting server in https://github.com/jupyterhub/jupyter-server-proxy/tree/main/tests/resources (similar to the websocket one perhaps) 2. Create tests in `test_proxy` similar to the websocket tests...
ok, I've done one round of review @ganisback! Hope this helps. @manics I think we should definitely add this feature! Ideally, I'd have liked us to make *everything* streaming, but...
Hey @ganisback! Just wanted to check to see if there's anything else I can do to help you move this forward :) I just ran into this again in a...
@ganisback it was slightly tricky, but I think I have a useful test for you at https://github.com/ganisback/jupyter-server-proxy/pull/1! It fails on main but passes on this branch! LMK what you think...
Sorry for dropping this, travel / vacation time :( I'll try to spend an hour on this later this week.
I still don't like using regexes for parsing headers, but I this is a clear improvement over status quo. So I've rebased this, and will merge. Apologies for the long...