html-table-extractor icon indicating copy to clipboard operation
html-table-extractor copied to clipboard

Published 20 hours ago • verified publisher icon yuanxu-li

Fix for passing None as id skips tables that have id

Open gondzo opened this issue 7 years ago • 2 comments

gondzo avatar Jan 26 '18 12:01 gondzo

Could you add more details on what bug it tries to fix?

yuanxu-li avatar Jan 31 '18 07:01 yuanxu-li

@gondzo I think I just came across the issue you were trying to fix :) Thanks for figuring out the issue and the fix! (It took me a while to figure out how to reproduce it ^_^!!!)

Sorry I was not able to merge your request, since I went with a different approach to fix in (https://github.com/yuanxu-li/html-table-extractor/pull/17). Feel free to add any test cases, and I'd be glad to merge it in

yuanxu-li avatar Feb 24 '19 00:02 yuanxu-li