npm-publish-git icon indicating copy to clipboard operation
npm-publish-git copied to clipboard

Add --dir arg to support building pakages that are not in the root

Open hedgepigdaniel opened this issue 6 years ago • 3 comments

This is useful for monorepos, where you have multiple NPM packages in subdirectories which are published separately.

TODO

  • [x] The package.json from the sub package should be published (not the root)

hedgepigdaniel avatar May 30 '19 08:05 hedgepigdaniel

Hi. Thanks for the contribution. I have a couple of comments on the PR but first i just want to check with you this: are you saying that in a monorepo it doesn't work to do 'cd path2pkg && npm-publish-git'?

andreineculau avatar May 30 '19 14:05 andreineculau

are you saying that in a monorepo it doesn't work to do 'cd path2pkg && npm-publish-git'?

Yes: because there is an assumption that the .git directory is in the same directory as the package to be published. So it fails when the .git directory does not exist.

hedgepigdaniel avatar Jun 03 '19 23:06 hedgepigdaniel

Yeah, let us know if there's anything we can do to push this pr forwards and get it merged 🙂

ScriptedAlchemy avatar Jun 03 '19 23:06 ScriptedAlchemy