android-transcoder icon indicating copy to clipboard operation
android-transcoder copied to clipboard

Validate encoders using MediaCodecList

Open selsamman opened this issue 6 years ago • 3 comments
trafficstars

It seems that validation of encoders was hard coded rather than using MediaCodecList. In the case of passthrough transcoding this can cause failures. This was cherry-picked from my fork which has tests and all tests ran with this code. I did not test it with the upstream repo.

selsamman avatar Apr 12 '19 08:04 selsamman

This relates to https://github.com/ypresto/android-transcoder/issues/76

selsamman avatar Apr 12 '19 08:04 selsamman

Thanks @selsamman, great commit!

jonmaim avatar Jun 26 '19 10:06 jonmaim

Thats validation is intended: combinations of container x video-codec x audio-codec are so many but has limitation. Also uncommon combinations are not guaranteed to be supported on all (most of) devices.

Since this library is intended to generate video with stable format, I prefer common, frequently used combination for stability.

ypresto avatar Aug 19 '19 03:08 ypresto