stickybits icon indicating copy to clipboard operation
stickybits copied to clipboard

Published 20 hours ago • verified publisher icon yowainwright

Start position needs to count also element offset

Open Kilbourne opened this issue 3 years ago • 1 comments

Fixes https://github.com/yowainwright/stickybits/issues/49

Kilbourne avatar Apr 28 '22 15:04 Kilbourne

@Kilbourne thanks for the PR!

Sorry I haven't released the TS version yet. Maybe I will do that after this PR! 😥

Can you add a Unit test or 2 codepens or sandboxes to show what you've fixed? 🙏

When I do a quick glance here, it gets foggy if the change in this PR would address all use cases.

Previously, I've received PRs to fix a single usecase where Stickybit's entire set of features must still work. I'm just more hesitant now. 🙏

Thanks!

Jeff

yowainwright avatar Apr 28 '22 16:04 yowainwright