Pytorch-NLU icon indicating copy to clipboard operation
Pytorch-NLU copied to clipboard

Ability to filter tests that didn't use puppeteer from root-cause ls

Open benjamingr opened this issue 5 years ago • 3 comments

Currently even tests that had no actions are shown in root-cause ls

Reported by @talkl

benjamingr avatar Sep 23 '20 11:09 benjamingr

This is because there's attach call and testEnd calls, so result folder is create for the test under that run.

We can in some point ignore if there are 0 steps, But we need to think what do to on test failure

Bnaya avatar Sep 23 '20 11:09 Bnaya

We can in some point ignore if there are 0 steps, But we need to think what do to on test failure

We should, and it also creates an issue in root-cause cloud

benjamingr avatar Sep 23 '20 11:09 benjamingr

This is because there's attach call and testEnd calls, so result folder is create for the test under that run.

We can in some point ignore if there are 0 steps, But we need to think what do to on test failure

@Bnaya There can be a beforeEach hook, that turns some boolean in TestContext to true. If this flag is true, this means that at least one step started, so we know there is something to report, Even if the first step failed and whole test failed following it.

gioragutt avatar Oct 10 '20 13:10 gioragutt