hashids-java icon indicating copy to clipboard operation
hashids-java copied to clipboard

Published 20 hours ago • verified publisher icon yomorun

V2 Proposal

Open 0x3333 opened this issue 7 years ago • 17 comments
trafficstars

Version 2.0 Proposal

This issue will be a discussion point to exchange ideas about version 2.0.

Big picture

The community is urging for a more java idiom version, and the current version can't handle these changes, that's why I'm proposing a new version, incorporating all the needs from the community in a broad discussion.

What about v2?

The new version must be compatible with original implementation as much as it can, without sacrificing java idiom. We will discuss how it will be implemented and the design considerations will be made here.

@cazacugmihai Proposal

  • [ ] Use of char arrays and StringBuilder instead of Strings
  • [ ] Precompute and cache recurrent operations
  • [ ] Helper class (CharUtils) for working with char arrays

@iggymoran Proposal

  • [] Relax MAX_NUMBER restriction

@KangoV Proposal

  • [] BigInteger as input/output

Reference implementation PR #53.

0x3333 avatar Feb 28 '18 19:02 0x3333

We can include these points in the TODO list.

Also, the 2.0.0 branch can be started from this point.

cazacugmihai avatar Feb 28 '18 20:02 cazacugmihai

Has this library gone dark? Haven't been any updates for about 6 months?

kmandeville avatar May 22 '18 19:05 kmandeville

I'd would say it is stable... :)

As soon as I have some time, I'll work on 2.0.

0x3333 avatar May 22 '18 20:05 0x3333

:)

Yes, definitely stable! I was mainly wondering because of some issues I had been following to see if there were any updates or if there were going to be. It wasn't anything major. Just an edge case around ArrayIndexOutOfBoundsException being thrown. We can work around it though. Thanks!

kmandeville avatar May 23 '18 02:05 kmandeville

Mind opening an issue for this ArrayIndexOutOfBoundsException?

0x3333 avatar May 23 '18 12:05 0x3333

There was one already that I thought you had fixed, but I was waiting for a new release. It doesn't look like there was one. https://github.com/jiecao-fm/hashids-java/issues/45

On Wed, May 23, 2018 at 8:22 AM, Tercio Gaudencio Filho < [email protected]> wrote:

Mind opening an issue for this ArrayIndexOutOfBoundsException?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jiecao-fm/hashids-java/issues/55#issuecomment-391326800, or mute the thread https://github.com/notifications/unsubscribe-auth/ABql-N_-Wqv3a6R3pgv19f1fW5O7Qcmwks5t1VSYgaJpZM4SXN7i .

kmandeville avatar May 23 '18 12:05 kmandeville

It was issued... 1.0.3. Maybe this is another bug...

0x3333 avatar May 23 '18 12:05 0x3333

Any chance of being able to accept BigInteger as input/output?

KangoV avatar Aug 03 '18 10:08 KangoV

what happened with v2? still not released...

eriknyk avatar May 01 '20 17:05 eriknyk

ping

XhstormR avatar Jun 06 '22 07:06 XhstormR

@0x3333 seems busy. is there anyone interest in v2.0 implementation? @eriknyk @XhstormR

fanweixiao avatar Jun 07 '22 03:06 fanweixiao

@fanweixiao yes

eriknyk avatar Jun 07 '22 03:06 eriknyk

Hi everyone. Sorry for the long delay, I'm quite busy here.

I believe a v2 is a must, I'll try to work it out next week. Any new requirements?

0x3333 avatar Jun 07 '22 12:06 0x3333