koa-webpack-dev-middleware icon indicating copy to clipboard operation
koa-webpack-dev-middleware copied to clipboard

webpack5 don‘t support?

Open smileBeauty opened this issue 4 years ago • 7 comments

context.compiler.plugin("done", share.compilerDone); context.compiler.plugin is not a function

smileBeauty avatar Mar 18 '21 06:03 smileBeauty

+1 , I have same problem

avivijiang avatar Mar 23 '21 06:03 avivijiang

+1 , I have same problem

yinshipeng avatar Jan 07 '22 12:01 yinshipeng

+1,I have the same problem

devil1989 avatar Jun 09 '22 03:06 devil1989

@yiminghe I thinks you can easily support it by changing the webpack-dev-middleware from a dependency to a peerDependency. It works on me.

And btw, res.getHeader is used in webpack-dev-middleware. I think we should also bridge this method.

addlistener avatar Sep 06 '22 12:09 addlistener

@yiminghe I thinks you can easily support it by changing the webpack-dev-middleware from a dependency to a peerDependency. It works on me.

And btw, res.getHeader is used in webpack-dev-middleware. I think we should also bridge this method.

Can you send a pull request?

yiminghe avatar Sep 06 '22 14:09 yiminghe

https://github.com/yiminghe/koa-webpack-dev-middleware/compare/2.x...jchnxu:break_deps?expand=1

https://github.com/yiminghe/koa-webpack-dev-middleware/compare/master...jchnxu:break_deps?expand=1

Theres's only readme diff between master & 2.x. Do you think we should consider deprecating 2.x since there's no real difference?

addlistener avatar Sep 08 '22 07:09 addlistener

https://github.com/yiminghe/koa-webpack-dev-middleware/compare/2.x...jchnxu:break_deps?expand=1

https://github.com/yiminghe/koa-webpack-dev-middleware/compare/master...jchnxu:break_deps?expand=1

Theres's only readme diff between master & 2.x. Do you think we should consider deprecating 2.x since there's no real difference?

ok

yiminghe avatar Sep 08 '22 13:09 yiminghe