yii2-httpclient icon indicating copy to clipboard operation
yii2-httpclient copied to clipboard

Published 20 hours ago • verified publisher icon yiisoft

Enh #204

Open zmoddynamics opened this issue 5 years ago • 1 comments

Adds 3 new header keys to $headerCollection.

  1. 'http-status-line': The full status line (ie. 'HTTP/1.1 200 OK')
  2. 'http-version': The http version returned from the server (ie. 'HTTP/1.1')
  3. 'http-status-code-reason-phrase': The status line without the HTTP version (ie. '200 OK')
Q A
Is bugfix? no
New feature? yes
Breaks BC? no
Tests pass? yes
Fixed issues #204

zmoddynamics avatar May 17 '20 02:05 zmoddynamics

Thank you for putting effort in the improvement of the Yii framework. We have reviewed your pull request.

In order for the framework and your solution to remain stable in the future, we have a unit test requirement in place. Therefore we can only accept your pull request if it is covered by unit tests.

Could you add these please?

Thanks!

P.S. If you have any questions about the creation of unit tests? Don't hesitate to ask for support. More information about unit tests

This is an automated comment, triggered by adding the label pr:request for unit tests.

yii-bot avatar May 17 '20 16:05 yii-bot