db-sqlite
db-sqlite copied to clipboard
ColumnSchema classes for performance of typecasting
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ✔️ |
| Fixed issues | yiisoft/db#737 |
PR Summary
-
Deprecated
ColumnSchemaClass and IntroducedJsonColumnSchemaClass TheColumnSchemaclass is now marked as deprecated, and a new class namedJsonColumnSchemais introduced, hinting at a shift towards handling JSON type data. -
New Interface
Column\ColumnSchemaInterfaceA new interface,Column\ColumnSchemaInterface, was added suggesting an abstraction that classes dealing with column schemas need to implement. -
Enhanced
SchemaClass TheSchemaclass received an update, wheresize,precision, andscaleproperties are now included in the array of column information. This change offers more specifics about column information. -
Refactored
loadColumnSchemaMethod inSchemaClass TheloadColumnSchemamethod in theSchemaclass has been refactored to use the newly updated column information array and is now capable of handling distinct data types, enhancing its scope and functionality. -
Removed
createColumnSchemaMethod fromSchemaClass ThecreateColumnSchemamethod was removed from theSchemaclass, suggesting a revision in the way column schemas are created. -
Test Class Update with New Column Schema Classes The
ColumnSchemaTestclass now includes new column schema classes such asBinaryColumnSchema,BooleanColumnSchema,DoubleColumnSchema,IntegerColumnSchema,JsonColumnSchema,StringColumnSchema. The addition of these classes demonstrates the PR's attempt to improve testing for different categories of column schemas. -
Test Refactoring in
ColumnSchemaTestClass The tests in theColumnSchemaTestclass have been refactored to utilize the new column schema classes, enhancing the testing scope and coverage.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.33%. Comparing base (
85a1939) to head (711c381).
:exclamation: Current head 711c381 differs from pull request most recent head eae08a9
Please upload reports for the commit eae08a9 to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## master #273 +/- ##
============================================
- Coverage 98.46% 97.33% -1.14%
Complexity 339 339
============================================
Files 21 19 -2
Lines 1043 1049 +6
============================================
- Hits 1027 1021 -6
- Misses 16 28 +12
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.