neural-collaborative-filtering icon indicating copy to clipboard operation
neural-collaborative-filtering copied to clipboard

The code implementation does not match the original paper

Open WANGBohaO-jpg opened this issue 2 years ago • 2 comments

The function _sample_negative in data.py appears to be incorrect. It currently utilizes ratings to generate negative samples, resulting in the exclusion of test items for each user from the negative samples. But the test items should be treated as negative samples in training set.

WANGBohaO-jpg avatar Jun 18 '23 12:06 WANGBohaO-jpg

@WANGBohaO-jpg Thanks for pointing out this. Would you like to create a pull request to fix the issue?

yihong-chen avatar Jun 19 '23 20:06 yihong-chen

@yihong-chen I created a full request, which is able to produce comparable results to the one reported in the paper. Have a look.

patelrajnath avatar May 03 '24 09:05 patelrajnath

This is solved by Raj's contribution. See pull request #23 for more details.

yihong-chen avatar Jun 23 '24 09:06 yihong-chen

Closed as complete.

yihong-chen avatar Jun 23 '24 09:06 yihong-chen