codeigniter-queue-worker icon indicating copy to clipboard operation
codeigniter-queue-worker copied to clipboard

Published 20 hours ago • verified publisher icon yidas

In CodeIgniter3 Router class methods was changed, if CI3 is detected …

Open ig0rb opened this issue 5 years ago • 6 comments

In CodeIgniter3 Router class methods was changed, if CI3 is detected the new methods are used.

I created a version check method to match CI version…the new methods are used

ig0rb avatar Dec 13 '19 18:12 ig0rb

Hi @ig0rb ,

Could you provide the official change of CI Router class methods for our reference?

Thank you for your support

yidas avatar Dec 15 '19 02:12 yidas

Hi, https://codeigniter.com/user_guide/installation/upgrade_300.html?highlight=fetch_directory

In the 3.0.0 there was a retrocompatibility, now i'm using 3.2-dev and old method's was removed.

You are welcome, you did a very usefull librariy :)

ig0rb avatar Dec 17 '19 08:12 ig0rb

Hi @ig0rb,

Good work!

I'm considering that we can force change the fetch_directory to a new attribute which supports all version 3 series. In this way, we can delete the CI version detection method and the IF statement.

What do you think?

yidas avatar Dec 24 '19 02:12 yidas

yes, I agree with you

ig0rb avatar Dec 26 '19 23:12 ig0rb

@ig0rb

Great!

You can refer to the discussion above to re-PR, I will merge it!

yidas avatar Dec 27 '19 09:12 yidas