grunt-filerev
grunt-filerev copied to clipboard
Updated PR#68 to also change the file reference inside of a source map file to point to file revisioned source file; updates a test
Updates pull-request #68, (fixes #62)
I thought the file reference in the source map file should point back to the file it's mapping.
Doing so, my code triggered the test 'should use same revision as .js source for the .map' to fail. I refactored it in a way that I think should be fine?
This code also introduces NodeJS Path Module to the tests.
Found issue where sourcemap is not being rev'd if it's not in the same directory
so, if I remove the part where it renames the file property's value in the source map it would be okay, right?
the issue I was originally trying to solve is that when file-rev renames both the file and the source map, the comment in the .js or .css file should point to the rev'd source file.
No idea what you're talking about, but my comment was referring to your home-made regex and that it's better to use an existing module for handling sourcemap comment rewriting.
Im referring to #62.
Huh, I didn't know people used base64-encoded sourcemaps. That's kinda nifty I guess.
Hey @sgnl any update on this?
Currently, I have my code working for me on my own project right now. If there is anything that needs to be changed LMK!
This issue is bugging me as well. Why has it not been merged yet?
@sindresorhus updated PR that doesn't use our own regex #80