grunt-filerev icon indicating copy to clipboard operation
grunt-filerev copied to clipboard

Updated PR#68 to also change the file reference inside of a source map file to point to file revisioned source file; updates a test

Open sgnl opened this issue 10 years ago • 9 comments

Updates pull-request #68, (fixes #62)

I thought the file reference in the source map file should point back to the file it's mapping.

Doing so, my code triggered the test 'should use same revision as .js source for the .map' to fail. I refactored it in a way that I think should be fine?

This code also introduces NodeJS Path Module to the tests.

sgnl avatar Nov 22 '14 03:11 sgnl

Found issue where sourcemap is not being rev'd if it's not in the same directory

sgnl avatar Nov 27 '14 03:11 sgnl

so, if I remove the part where it renames the file property's value in the source map it would be okay, right?

the issue I was originally trying to solve is that when file-rev renames both the file and the source map, the comment in the .js or .css file should point to the rev'd source file.

sgnl avatar Nov 28 '14 10:11 sgnl

No idea what you're talking about, but my comment was referring to your home-made regex and that it's better to use an existing module for handling sourcemap comment rewriting.

sindresorhus avatar Nov 29 '14 16:11 sindresorhus

Im referring to #62.

sgnl avatar Nov 29 '14 19:11 sgnl

Huh, I didn't know people used base64-encoded sourcemaps. That's kinda nifty I guess.

nelsonpecora avatar Dec 01 '14 03:12 nelsonpecora

Hey @sgnl any update on this?

nelsonpecora avatar Jan 07 '15 15:01 nelsonpecora

Currently, I have my code working for me on my own project right now. If there is anything that needs to be changed LMK!

sgnl avatar Jan 10 '15 03:01 sgnl

This issue is bugging me as well. Why has it not been merged yet?

jtheoof avatar Feb 12 '15 22:02 jtheoof

@sindresorhus updated PR that doesn't use our own regex #80

nelsonpecora avatar Mar 25 '15 16:03 nelsonpecora