generator-generator icon indicating copy to clipboard operation
generator-generator copied to clipboard

Published 20 hours ago • verified publisher icon yeoman

Coverage should exclude the template folder

Open SBoudrias opened this issue 10 years ago • 12 comments
trafficstars

Title is pretty self explicit. We don't want to cover JS files inside the template folder.

SBoudrias avatar Nov 18 '15 09:11 SBoudrias

does it include?

udnisap avatar Nov 26 '15 17:11 udnisap

@udnisap sorry, what do you mean?

SBoudrias avatar Nov 26 '15 17:11 SBoudrias

I am assuming you are referring to coverage.io reports. https://coveralls.io/builds/4282602 there are no templates

udnisap avatar Nov 27 '15 12:11 udnisap

Oh, I'm talking about the generated code. I removed template coverage manually from this repository, but the generated code still covers the template folder.

SBoudrias avatar Nov 27 '15 19:11 SBoudrias

It should be done at gulp-task? gulp-coverall doesn't provide any options to skip files.

hemanth avatar Dec 06 '15 10:12 hemanth

in the pre-test tasks.

SBoudrias avatar Dec 06 '15 20:12 SBoudrias

Just a '!**/templates/**' is the src is fine?

Well, I see specific files being mentioned in the src, no glob.

hemanth avatar Dec 07 '15 04:12 hemanth

In the generated code, not the project code.

SBoudrias avatar Dec 07 '15 05:12 SBoudrias

Ha ok, this change must be in 'node:app' right?

hemanth avatar Dec 07 '15 05:12 hemanth

Generate app has 100% coverage

udnisap avatar Dec 07 '15 13:12 udnisap

Ha ok, this change must be in 'node:app' right?

I think this sounds right. Should this be closed here and opened there? https://github.com/yeoman/generator-node/issues/new

eddiemonge avatar Dec 17 '15 01:12 eddiemonge

It'd probably require some changes on both sides, so we should keep it open here and figure how we want to pass that to generator-node (probably a new option).

SBoudrias avatar Dec 17 '15 04:12 SBoudrias