ArchGDAL.jl icon indicating copy to clipboard operation
ArchGDAL.jl copied to clipboard

Change `:geom` and empty column names to `:geometry`

Open rafaqz opened this issue 11 months ago • 6 comments

The default gdal geometry column name :geom is now in conflict with the GeoInterace.jl default of :geometry and julias tendency to spell things out. We have GeoInterface.geometrycolumns for packages, but its clunky for interactive use. Users want to just get the geometry column from a data frame in the normal dataframe syntax, with e.g. df.geometry and currently they are left guessing which package uses which name.

The fact that empty names are allowed is also a problem for users.

So I'm proposing we switch both :geom and empty names to :geometry.

https://github.com/JuliaGeo/GeoInterface.jl/issues/164

rafaqz avatar Dec 05 '24 10:12 rafaqz

Are we able to get a consensus on this? I think this would be good to standardize as early on as possible.

alex-s-gardner avatar Dec 12 '24 17:12 alex-s-gardner

I think we just need a PR

rafaqz avatar Dec 12 '24 17:12 rafaqz

I've read the discussions etc, and am supportive of this. Can we make sure the implementation allows users to opt-in/out of it?

yeesian avatar Dec 12 '24 17:12 yeesian

I guess we can have a geometrycolum keyword with :geometry as the default?

rafaqz avatar Dec 12 '24 17:12 rafaqz

So are we just adding an option to rename the geometry column in: https://github.com/yeesian/ArchGDAL.jl/blob/2e0a4a7f83398be54e19a0a1a3e6918b41f70cef/src/tables.jl#L1

alex-s-gardner avatar Dec 12 '24 18:12 alex-s-gardner

A decision was made to standardize geometry name in GeoDataFrames.jl... this issue can be closed.

alex-s-gardner avatar Jan 07 '25 23:01 alex-s-gardner