ArchGDAL.jl icon indicating copy to clipboard operation
ArchGDAL.jl copied to clipboard

Published 20 hours ago • verified publisher icon yeesian

Forward GeoInterface.centroid

Open asinghvi17 opened this issue 2 years ago • 2 comments

~This doesn't work for FeatureCollections yet, and no tests have been added. It's essentially a quick and dirty implementation where I extended the type constraints on the main GeoInterface.convert method and implemented ArchGDAL.geointerface_geomtype(arg) = IGeometry. Since it operates on traits, it seemed a fair bet, and any feature-like object can of course be overloaded.~

Changed the PR to just forward GeoInterface.centroid, which seemed to be missing.

asinghvi17 avatar Jan 19 '23 11:01 asinghvi17

This is already tested as working. But yes we also need to handle features somehow. I guess I should have handle that in GeoInterface as well.

rafaqz avatar Jan 19 '23 11:01 rafaqz

A test ?

rafaqz avatar Jan 26 '23 10:01 rafaqz