ydb-go-sdk
ydb-go-sdk copied to clipboard
Added Isolation concept
Pull request type
Please check the type of change your PR introduces:
- [ ] Bugfix
- [x] Feature
- [ ] Code style update (formatting, renaming)
- [x] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] Documentation content changes
- [ ] Other (please describe):
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information
github.com/ydb-platform/ydb-go-sdk/v3/query
compatible changes
Isolation: added OnlineRO: added OnlineROWithInconsistentReads: added SerializableRW: added SnapshotRO: added StaleRO: added
github.com/ydb-platform/ydb-go-sdk/v3/table
incompatible changes
Options.TxSettings: changed from *TransactionSettings to *TransactionSettings Session.BeginTransaction: changed from func(context.Context, *TransactionSettings) (Transaction, error) to func(context.Context, *TransactionSettings) (Transaction, error) TransactionSettings: changed from github.com/ydb-platform/ydb-go-sdk/v3/internal/tx.Settings to github.com/ydb-platform/ydb-go-sdk/v3/internal/tx.Options TxSettings: changed from func(...TxOption) *TransactionSettings to func(...TxOption) *TransactionSettings WithTxSettings: changed from func(*TransactionSettings) txSettingsOption to func(*TransactionSettings) txSettingsOption
summary
Base version: v3.108.1 (master) Cannot suggest a release version. Incompatible changes were detected.
Codecov Report
Attention: Patch coverage is 22.58065% with 48 lines in your changes missing coverage. Please review.
Project coverage is 70.96%. Comparing base (
4b3e883) to head (263da45).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| internal/tx/isolation.go | 0.00% | 38 Missing :warning: |
| internal/tx/settings.go | 52.38% | 10 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #1739 +/- ##
==========================================
- Coverage 71.02% 70.96% -0.06%
==========================================
Files 383 384 +1
Lines 39152 39206 +54
==========================================
+ Hits 27807 27823 +16
- Misses 10205 10247 +42
+ Partials 1140 1136 -4
| Flag | Coverage Δ | |
|---|---|---|
| experiment | 70.51% <22.58%> (-0.09%) |
:arrow_down: |
| go-1.21.x | 70.83% <22.58%> (-0.14%) |
:arrow_down: |
| go-1.24.x | 70.95% <22.58%> (-0.01%) |
:arrow_down: |
| integration | 53.50% <22.58%> (-0.41%) |
:arrow_down: |
| macOS | 38.22% <3.22%> (-0.06%) |
:arrow_down: |
| ubuntu | 70.96% <22.58%> (-0.06%) |
:arrow_down: |
| unit | 38.22% <3.22%> (-0.07%) |
:arrow_down: |
| windows | 38.21% <3.22%> (-0.06%) |
:arrow_down: |
| ydb-24.1 | 51.33% <22.58%> (+0.08%) |
:arrow_up: |
| ydb-24.2 | 51.28% <22.58%> (-0.37%) |
:arrow_down: |
| ydb-24.3 | 51.79% <22.58%> (+0.03%) |
:arrow_up: |
| ydb-24.4 | 51.75% <22.58%> (-0.01%) |
:arrow_down: |
| ydb-25.1 | 53.39% <22.58%> (-0.05%) |
:arrow_down: |
| ydb-nightly | 70.51% <22.58%> (-0.09%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.