ycmd
ycmd copied to clipboard
Fixes submodule cwd in build.py
@puremourning Updated
Codecov Report
Merging #1562 (8d1e53d) into master (c3abcc7) will decrease coverage by
0.06%. The diff coverage isn/a.
:exclamation: Current head 8d1e53d differs from pull request most recent head 951da32. Consider uploading reports for the commit 951da32 to get more accurate results
@@ Coverage Diff @@
## master #1562 +/- ##
==========================================
- Coverage 96.38% 96.32% -0.07%
==========================================
Files 90 90
Lines 7839 7839
Branches 164 164
==========================================
- Hits 7556 7551 -5
- Misses 230 235 +5
Partials 53 53
@puremourning I fixed it and now the --print option works.
@puremourning Why does the CodeCov fail ?
1 is a v good point. Though YCM has few submodules now, it still makes this only partially affective.
2 - I thought of this too then thought ‘it’s ok because it only does this when dir is empty’. But it occurs to me (as it did then) that this change should omly plapply tonempty subdirs ie do it per directory not ‘everywhere’
what's the status of this PR ?
@puremourning Do I have to make any changes ?
I think just fix the conflicts and we can merge it?
Seems abandoned, and I'm concerned about installations that aren't from git.