ycmd icon indicating copy to clipboard operation
ycmd copied to clipboard

Fixes submodule cwd in build.py

Open Limits0x opened this issue 4 years ago • 8 comments

This change is Reviewable

Limits0x avatar Apr 21 '21 07:04 Limits0x

@puremourning Updated

Limits0x avatar Apr 21 '21 08:04 Limits0x

Codecov Report

Merging #1562 (8d1e53d) into master (c3abcc7) will decrease coverage by 0.06%. The diff coverage is n/a.

:exclamation: Current head 8d1e53d differs from pull request most recent head 951da32. Consider uploading reports for the commit 951da32 to get more accurate results

@@            Coverage Diff             @@
##           master    #1562      +/-   ##
==========================================
- Coverage   96.38%   96.32%   -0.07%     
==========================================
  Files          90       90              
  Lines        7839     7839              
  Branches      164      164              
==========================================
- Hits         7556     7551       -5     
- Misses        230      235       +5     
  Partials       53       53              

codecov[bot] avatar Apr 21 '21 09:04 codecov[bot]

@puremourning I fixed it and now the --print option works.

Limits0x avatar Apr 21 '21 13:04 Limits0x

@puremourning Why does the CodeCov fail ?

Limits0x avatar Apr 21 '21 13:04 Limits0x

1 is a v good point. Though YCM has few submodules now, it still makes this only partially affective.

2 - I thought of this too then thought ‘it’s ok because it only does this when dir is empty’. But it occurs to me (as it did then) that this change should omly plapply tonempty subdirs ie do it per directory not ‘everywhere’

puremourning avatar Apr 25 '21 10:04 puremourning

what's the status of this PR ?

puremourning avatar Nov 04 '21 20:11 puremourning

@puremourning Do I have to make any changes ?

Limits0x avatar Nov 05 '21 02:11 Limits0x

I think just fix the conflicts and we can merge it?

puremourning avatar Aug 13 '22 14:08 puremourning

Seems abandoned, and I'm concerned about installations that aren't from git.

puremourning avatar Sep 29 '22 19:09 puremourning