headspace-cli
headspace-cli copied to clipboard
Improvements
Thanks for your project. I made some improvement for me. If you want, you can integrate it.
fix: migrate language env variable to a parameter (--language) We need to create a global env variable to working with exe file in Windows. Moreover, language is managed like others parameters
feat: add tags mp3 files (add eyed3 dependencies) Useful to manage mp3 files
feat: add --check parameter to force apps to check again downloaded file With this parameter is possible to redownload audio files that are missing
fix: clean folder name to not rise an exception (windows)
fix: call cli() in main to debug properly Python us not my coding language but it seems better like that
Just ran into the folder-name error, thanks for the fix @malys and please accept the pull request @yashrathi-git :)
@malys I just noticed, when I try to run your updated script, I always get a KeyError at line 257 after the description of the pack is printed out (where it should say "downloading ...")
I think it's because the response is no deep dictionary, but instead contains only one key called 'url' with its value.
@Clemens123 You can propose some fix creating PR (here or on my fork). I will integrate it
@malys Thank you for the PR and patience. You have done too many changes in just one PR, it would be great if you could open a separate PR for fixing the filename issue and adding appropriate tags to the file.
@yashrathi-git at the beginning, It was only 1 fix but using cli apps, I have discovered some instabilities and added some useful features to cover my needs. Sorry but I haven't time to create more PR. I have tried to create different commits and add comments to new functions. Moreover, I'm not using Headspace anymore.