yarpc-go icon indicating copy to clipboard operation
yarpc-go copied to clipboard

internal/observability: Adding metricProcedure field

Open elliotchance opened this issue 9 months ago • 3 comments
trafficstars

The metricProcedure replicates the behavior of a variety of internal libraries when converting the procedure for metrics (M3). This field is critical to being able to support log correlation with metrics. See ERD for full details.

https://docs.google.com/document/d/1B45wjZDQL0olCoENh3XYMyvCPI2A3hw8OeU2IhrtBtA

  • [ ] Description and context for reviewers: one partner, one stranger
  • [ ] Docs (package doc)

RELEASE NOTES:

New metricProcedure log field will contain M3-compatible lookup values for the YARPC procedure.

elliotchance avatar Feb 24 '25 20:02 elliotchance

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Feb 24 '25 20:02 CLAassistant

Have we considered just making this a breaking change in logs?

Folks cannot setup alerts, which is convenient - nobody will get paged. There will be some minor chaos for a day or two, but I think I would stamp this - the goal would be to reduce the future confusion and noise.

rabbbit avatar Feb 28 '25 04:02 rabbbit

Have we considered just making this a breaking change in logs?

I think, it may be useful to have a yarpc-styled procedure name too. I mean, I personally use it all the time, though it might be a skew of library owner.

biosvs avatar Mar 06 '25 20:03 biosvs