Jaroslav Škarvada

Maybe the instance_create/destroy could be more generic, i.e.: * instance_create could have a list of devices or regular expressions to match devices to immediately try to hotplug. Watchout for the...

Fedora rawhide CI failure is caused by regression in the kernel: https://bugzilla.redhat.com/show_bug.cgi?id=2262526

@adriaan42 please fix the CodeQL found problems.

IMHO: dee5d6f63aab46427ade7415babf3c5ef1488c52 - it's OK for merge now aad02c76e152bed9aea7a34846a013278db973f8 - tighten the policy (per inline comment) and it's probably OK 17b528c0d2065ff902d6ceb00407569c2a8f2c05 - this still needs some work, see comments

>### Some open points > >* **Deleting instances**: I have removed the `_created_dynamically` flag and respective checks, so also non-dynamically-created instances can be deleted. Should there be rules here? E.g.,...

> IMHO: >[dee5d6f](https://github.com/redhat-performance/tuned/commit/dee5d6f63aab46427ade7415babf3c5ef1488c52) - it's OK for merge now >[aad02c7](https://github.com/redhat-performance/tuned/commit/aad02c76e152bed9aea7a34846a013278db973f8) - tighten the policy (per inline comment) and it's probably OK >[17b528c](https://github.com/redhat-performance/tuned/commit/17b528c0d2065ff902d6ceb00407569c2a8f2c05) - this still needs some work, see comments...

> > > IMHO: > > > [dee5d6f](https://github.com/redhat-performance/tuned/commit/dee5d6f63aab46427ade7415babf3c5ef1488c52) - it's OK for merge now > > > [aad02c7](https://github.com/redhat-performance/tuned/commit/aad02c76e152bed9aea7a34846a013278db973f8) - tighten the policy (per inline comment) and it's probably OK >...

> > Thanks. Regarding the second PR I thought it's good enough for the basic functionality and could be improved later. But if you want to do it right +1...

> > * How do we want to handle (physical) hotplugging of devices, which leads to adding/removal of IRQs in the system? Do we need to periodically scan `/proc/irq` and...

Uncore support is currently worked on #576. If you mean the following line from the `powersave` TuneD profile: ``` governor=ondemand|powersave ``` It means governor is set to `ondemand` and if...