Jaroslav Škarvada

Results 257 comments of Jaroslav Škarvada

> but means we still `need _has_dynamic_options`, which is marked as a hack in plugins/base.py. It's OK for me, in long-term it's a candidate for rewrite/refactor, but there are other...

Regarding the cgroups, there is support for cgroups v1 in the scheduler plugin and we would also like to add support for the v2 for completeness. It could be useful...

Sorry for the delay, but hopefully it's not urgent, although it's very nice RFE. > * Determine the "first instance": The way as implemented in the `cpu` plugin does not...

> * We no longer need `ignore`. An empty affinity list means "don't touch". > OK. > * `calc` means "derive affinity from `isolated_cores`". We don't have that variable in...

What about using unit suffix to distinguish between percentage and kHz? Then we could avoid the possible conflict between kHz and percentage setting. E.g. we used something similar in `readahead`...

Uncore support has been merged, if you want the setting in the `throughput-performance` profile, please update this PR or create new one.

> > for non-active instances, instance_apply_tuning (https://github.com/redhat-performance/tuned/blob/master/tuned/plugins/base.py#L250, and related functions) immediately returns, so in particular, the static tuning is not executed -> it is not possible to have static instance-specific...

LGTM. I also tested basic functionality and it seems everything works OK, thanks for contribution.