Jaroslav Škarvada

Results 258 comments of Jaroslav Škarvada

TuneD has the switch_profile method and has throughput-performance, balanced, and powersave basic profiles. This is there for cca. decade. Currently, we don't plan to add logic for auto switching profiles...

> > Currently, we don't plan to add logic for auto switching profiles e.g. according to the battery charge level or temporarily holding profiles - upper layer should handle it...

Unauthorized user is not allowed to do any changes that requires authorization, so it shouldn't be security related. I agree the code could be improved to disable all the options...

LGTM, please don't forget that we will have to revert this in RHEL-9 and FDP downstreams by distro specific patch.

There is no need for atomic test & set or semaphores, because the signal handler is running in one thread thus the worst thing that could happen is that the...

It would be generally better and much cleaner to do the reloads in the main loop, but it would require bigger code changes.

> I'm not sure what I think about enabling this by default for the main stock profiles, mainly due to the new `upower` dependency and the fact that it basically...

I think it should reflect the `enable_dbus` main conf and `--no-dbus` command line option and also work without DBus (e.g. with limited functionality or with plugin disabled), because there are...

> I'm not sure what I think about enabling this by default for the main stock profiles, mainly due to the new `upower` dependency Regarding the upower, it should detect...

Also what about adding this functionality into the `video` plugin?