ember-tether icon indicating copy to clipboard operation
ember-tether copied to clipboard

Add support for Ember v5

Open SergeAstapov opened this issue 2 years ago • 6 comments

Without this change, you have an issue installing Ember.js v5:

unmet peer ember-source@^4.0.0: found 5.3.0

SergeAstapov avatar Oct 01 '23 02:10 SergeAstapov

Hmm, any idea what's going on with CI @SergeAstapov ?

lukemelia avatar Oct 02 '23 03:10 lukemelia

Also, this is compatible with Ember 3.28, so let's make the peer dep say as much

lukemelia avatar Oct 02 '23 03:10 lukemelia

Also, this is compatible with Ember 3.28, so let's make the peer dep say as much

not sure, as both readme and CI have 4.4+, but I can update of course to be 3.28+, which I think would be separate PR.

As for CI errors

Build Error (broccoli-persistent-filter:Babel > [Babel: @ember/test-helpers]) in @ember/test-helpers/-internal/build-registry.js

[BABEL]: Cannot find module '@babel/helper-get-function-arity'

this seen like lock file needs and update + maybe some reps. I should be able to take a look into that in separate PR

SergeAstapov avatar Oct 02 '23 12:10 SergeAstapov

Any updates here? I'd love to upgrade to Ember 5.x without using npm i --legacy-peer-deps.

paddor avatar Feb 16 '24 12:02 paddor

I haven't had time to look at this myself. I'm traveling but happy to review a PR.

lukemelia avatar Feb 16 '24 15:02 lukemelia

Handled in #129

lukemelia avatar Mar 12 '24 12:03 lukemelia

Should this be closed now?

RobbieTheWagner avatar Nov 29 '25 21:11 RobbieTheWagner