Yann Simon

Results 195 comments of Yann Simon

My other comment is that the current `Host` extractor is misleading. Personally, I'd have used it by assuming it's only using the `Host` header. By making it `Spoofable`, it's clearer...

@sclu1034 I agree with you. What kind of approach would you see here? Should we change those extractors to: - have extractors only about non-spoofable values - have separated extractors...

> Thank you for the fix! Note that `Later` is one of the `Leaf` descendants. The other two are `Always` and `Now`. I wonder if it makes sense to make...

@satorg thanks for coming back! I've updated the branch. The tests on scala 2.12 with scala native are failing, without any good error message.

now all tests have passed

When does a PR get merged? I could find any process described in https://github.com/typelevel/cats/blob/main/CONTRIBUTING.md ? Do you wait for 2 reviews?

I've updated the ember client with the following dependency update, but it does not fix the issue: ``` "org.http4s" %% "http4s-ember-client" % "0.23.25" ```

I'm trying the request with curl: ``` curl --head localhost:7880/test/this-index-does-not-exist/search/products HTTP/1.1 404 Not Found Server-Timing: pim-search;dur=8.43;desc="pim-search" x-correlation-id: pim-search/c4ec431b-7493-4fc4-b17c-c60541e72332 Server: pim-search Date: Fri, 12 Jan 2024 15:22:41 GMT Transfer-Encoding: chunked Content-Type:...

I've created a small reproduction: https://github.com/yanns/reproduce-head-issue The HTTP response I get from is a bit different from the one I get with the original application: it has a `Content-Length: 2`...

oh good catch. I've made it public now.