kubeconform icon indicating copy to clipboard operation
kubeconform copied to clipboard

Add test for refs caching

Open Nitive opened this issue 4 years ago • 2 comments
trafficstars

The problem with refs caching lays in gojsonschema code. There is a GET request which can't be cached on kubeconform side.

I think the best solution for caching refs would be to have http transport with supports caching and pass it to gojsonschema

  • Most code for caching can be deleted in favour of external module gregjones/httpcache
  • Easy to implement other caching method (just use one of the cache backend included in httpcache)
  • Standard interface means caching inside of gojsonschema code can be done as simple and passing http transport as argument (when and if gojsonschema supports it)

Nitive avatar Jan 09 '21 13:01 Nitive

yep that ll need patching gojsonschema.. might have a look, some day :)

yannh avatar Jan 09 '21 14:01 yannh

BTW thanks a lot for filing that bug https://github.com/xeipuuv/gojsonschema/issues/322 :+1:

yannh avatar Feb 28 '21 10:02 yannh

Closing, it looks like gojsonschema is not very actively maintained... and this will be fairly difficult to complete :(

yannh avatar Oct 16 '22 13:10 yannh

not sure what the point of a cache is if it can't be used offline I assume it saves some amount of requests 🤷

grosser avatar Mar 30 '23 21:03 grosser