Missing headers for compiling xtensor-zarr

[hankliu5]

Hello all,

I was trying to compile xtensor-zarr but found out that some zarray headers were not installed through make install. Those headers are:

${ZARRAY_INCLUDE_DIR}/zarray/zfunctors.hpp
${ZARRAY_INCLUDE_DIR}/zarray/zarray_impl_register.hpp
${ZARRAY_INCLUDE_DIR}/zarray/zmpl.hpp
${ZARRAY_INCLUDE_DIR}/zarray/zarray_temporary_pool.hpp
${ZARRAY_INCLUDE_DIR}/zarray/zinit.hpp
${ZARRAY_INCLUDE_DIR}/zarray/zreducers.hpp
${ZARRAY_INCLUDE_DIR}/zarray/zreducer.hpp
${ZARRAY_INCLUDE_DIR}/zarray/zreducer_options.hpp
${ZARRAY_INCLUDE_DIR}/zarray/zarray_zarray.hpp

It seems that those missing headers are not used directly in xtensor-zarr, but they are included for internal usages of other zarray headers.

I'm not sure whether it is the intention or not, but installing missing headers like #66 allows me to compile xtensor-zarr successfully.

Also, zarray depends on nlohmann_json, but this library is not mentioned in README/Dependencies.

-Hank

[JohanMabille]

I'm not sure whether it is the intention or not

This is definitely a bug. We reorganized the code a lot recently and missed that, thanks for finding it (and fixing it)!