xsimd icon indicating copy to clipboard operation
xsimd copied to clipboard

Add mixed-complex implementations of xsimd::pow()

Open jatinchowdhury18 opened this issue 3 years ago • 4 comments

Adding a specialization of xsimd::pow() for cases where only one of the two arguments is complex.

jatinchowdhury18 avatar May 12 '22 21:05 jatinchowdhury18

I'm not sure I understand why the unit tests are failing for xsimd::pow(real_batch, complex_batch), since the method is just forwarding the arguments to xsimd::pow(complex_batch, complex_batch), which is passing the unit tests. Unfortunately, I don't currently have a Linux machine that supports AVX512, so it's a bit difficult for me to debug the failures.

jatinchowdhury18 avatar May 24 '22 17:05 jatinchowdhury18

Hi, I have a processor capable of running AVX 512 instructions, so I ran the tests in your branch and all of them passed. Is it possible to run the CI again on this branch, so that we can see what the build logs say? I tried looking at them but it seems to me like they were deleted.

wermos avatar Jun 25 '22 05:06 wermos

Hi @wermos! I was also unable to track down the logs from the Azure Pipelines builds, however the Appveyor logs are still available, so here are the logs for the two runs that failed:

IIRC, the AVX-512 GCC runs were failing with the same error, but I've also made new commit to re-trigger the CI pipelines, so we should have new logs soon. Thanks!

jatinchowdhury18 avatar Jun 25 '22 09:06 jatinchowdhury18

@jatinchowdhury18 you can trigger the CI with an empty commit:

git commit --allow-empty -m "Triggers CI"
git push origin complex-pow

The empty commits will be automatically removed when the PR is merged.

JohanMabille avatar Jun 27 '22 08:06 JohanMabille