li@ng

Results 16 comments of li@ng

Ambiguity in the context styleguide.

Hi @matttproud , regardless of the SRP for mixing APIs under the context, still one confusion to me is: ``` type interface CustomContext { context.Context // ...additional APIs that we...

Ext-proc STREAMED mode with router Retry_policy will send duplicated request body

@yanjunxiang-google @tyxia any ideas? thanks!

Ext-proc STREAMED mode with router Retry_policy will send duplicated request body

Hello @tyxia @stevenzzzz thanks for the answers. I created a repo for you guys to reproduce easily: https://github.com/xr/envoy-issue as you can see: ``` ./test.sh 1000 -> ok ./test.sh 2000 ->...

Ext-proc STREAMED mode with router Retry_policy will send duplicated request body

@yanjunxiang-google haven't tested the earlier envoy version, iirc 1.30 the same behaviour.

Ext-proc STREAMED mode with router Retry_policy will send duplicated request body

@yanjunxiang-google thanks for taking a look, sorry was missed the ping before, here are some logs: [trace.log](https://github.com/user-attachments/files/18147080/trace.log) I have triggered payload size and here is the results from this time....

Ext-proc STREAMED mode with router Retry_policy will send duplicated request body

hello @stevenzzzz , the test side stream grpc just return continue back to the envoy: https://github.com/xr/envoy-issue/blob/d44520e983d7cfa19f14312e433f5bd73f43b7af/ext-proc/main.go#L88 > could you try in the response add/return 10 bytes for each rpc? IIUC,...