angular-ui-switch icon indicating copy to clipboard operation
angular-ui-switch copied to clipboard

create switch size option

Open EskoCruz opened this issue 10 years ago • 7 comments

Here is a solution for issue #25 by @tomerb15.
I created an attribute of "size" that have the options of "small" or "large".
By using: size="small" or size="large"
This will change the size of the switch.

image

EskoCruz avatar Oct 08 '15 15:10 EskoCruz

I like the idea, but wouldn't it be better to use a class - like "sm" or "lg" to create this behaviour? a bit more bootstrappy...

iJungleboy avatar Oct 16 '15 12:10 iJungleboy

Any progress on this PR? Would love to have it!

evdoks avatar Nov 04 '15 10:11 evdoks

@iJungleboy @evdoks - I am a little confused. Do you two just want a class of "sm" and "lg" or something more along the lines of "switchery-sm" and "switchery-lg"?
class="switchery-sm"
I may have this just about written out now, just need to verify before checking in this PR. :+1:

EskoCruz avatar Nov 04 '15 18:11 EskoCruz

My suggestion is just to add the class "sm" or "lg" - so you might have a class="green sm" and it would do both.

iJungleboy avatar Nov 13 '15 12:11 iJungleboy

@xpepermint This is ready to be reviewed and merged to the master branch.

EskoCruz avatar Dec 04 '15 18:12 EskoCruz

@EskoCruz that's awesome :+1: I hope @xpepermint will find time to go through the pulls soon :)

iJungleboy avatar Dec 07 '15 07:12 iJungleboy

I think it'd be better if you make that "size" attribute an integer so that I'm able to have many different sizes to choose instead of just 3 (small, medium or large).

yagotome avatar Mar 05 '17 18:03 yagotome