xorbits icon indicating copy to clipboard operation
xorbits copied to clipboard

DOC: Added environment.yml in CI

Open shark-21 opened this issue 2 years ago • 6 comments

What do these changes do?

Adds environment.yml

Related issue number

Fixes #329

shark-21 avatar Jun 11 '23 17:06 shark-21

Codecov Report

Merging #515 (33f28ae) into main (8e96864) will decrease coverage by 3.86%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #515      +/-   ##
==========================================
- Coverage   67.90%   64.04%   -3.86%     
==========================================
  Files        1001     1001              
  Lines       77649    77649              
  Branches    16135    16135              
==========================================
- Hits        52727    49731    -2996     
- Misses      22790    25860    +3070     
+ Partials     2132     2058      -74     
Flag Coverage Δ
unittests 64.00% <ø> (-3.83%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

see 152 files with indirect coverage changes

codecov[bot] avatar Jun 11 '23 17:06 codecov[bot]

Thanks for your contribution!

Since we have updated the dev documentation, and replace the mamba section with conda, I think an environmental.yml is not necessary.

What do you think?

UranusSeven avatar Jun 12 '23 03:06 UranusSeven

Yeah sure. I thought environment.yml file may be needed for the upcoming slurm deployment project also it might be convenient to add changes in the dependencies.

shark-21 avatar Jun 12 '23 17:06 shark-21

Yeah sure. I thought environment.yml file may be needed for the upcoming slurm deployment project also it might be convenient to add changes in the dependencies.

To my understanding, conda is also available for slurm environments.

Is that correct? @luweizheng @ChengjieLi28

UranusSeven avatar Jun 13 '23 02:06 UranusSeven

slurm environments

Do not get what you want to say. I think this PR does not affect SLURM deployment. As on a SLURM cluster, users can install what they want into a environment by using venv conda or any other env management tools. This PR only adds an environment.yml file required by contributors who want to build a local dev environment.

luweizheng avatar Jun 13 '23 02:06 luweizheng

So should issue #329 be closed ? or what else can I do ?

shark-21 avatar Jun 13 '23 05:06 shark-21