Xavier Olive

Results 56 comments of Xavier Olive

related to https://github.com/jupyter-widgets/ipyleaflet/issues/414

Well the line doesn't hurt, I actually remove the dtype argument on my side, but the warning is still there: ``` [hidden]/lib/python3.7/site-packages/ipyleaflet-0.11.3-py3.7.egg/ipyleaflet/leaflet.py:316: DeprecationWarning: metadata {'dtype': None} was set from the...

sounds legit you want me to do the PR or is it faster for you to just commit it?

## Review checklist for @xoolive ### Conflict of interest - [x] I confirm that I have read the [JOSS conflict of interest (COI) policy](https://github.com/openjournals/joss/blob/master/COI.md) and that: I have no COIs...

Dear @fxjung, Before I start trying to go into the code, I am having serious concerns about the quality of the paper and of the documentation. I entered your project...

Also please consider the item in our reviewer checklist for automated tests.

Thank you @fxjung I am sorry I spoke too fast about the tests, I just missed them :fearful: I will have a look! To be honest, I still recommend improving...

@fxjung the documentation looks quite good! I think I am ok with what's left. Consider regenerating the pdf to help fellow reviewers checking the latest version of the statement paper.

No worry, I also have a real job aside 😉 You should be able to run the code from traffic, but be careful to get it from the `lonboard` branch...

Je viens de regarder ton code à cause du conflit ci-dessus, et en fait on dirait qu'il y a des fonctions à la place de classes qui dupliquent le job...