rav1e icon indicating copy to clipboard operation
rav1e copied to clipboard

Update dependencies which do not bump minimum rustc

Open shssoichiro opened this issue 1 year ago • 5 comments

shssoichiro avatar Mar 10 '24 20:03 shssoichiro

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.54%. Comparing base (3c3a26f) to head (025a405). Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3359      +/-   ##
==========================================
+ Coverage   88.52%   88.54%   +0.01%     
==========================================
  Files          89       89              
  Lines       28323    28355      +32     
==========================================
+ Hits        25074    25107      +33     
+ Misses       3249     3248       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 10 '24 21:03 codecov[bot]

BTW I recommend using cargo-hack to validate MSRV (and other things): cargo +1.70 hack --each-feature check

Might be worth adding something to CI, although a job like that would take very long to complete...

FreezyLemon avatar Mar 10 '24 22:03 FreezyLemon

We do have CI jobs for validating minimum rust version. Just not one for wasm currently. hack might be useful for local testing before pushing up to CI.

shssoichiro avatar Mar 11 '24 00:03 shssoichiro

It looks like adding wasm tests in CI here may be a bit more complicated than in v_frame. But I'm also not an expert at Github actions. Anyway, for now I'll create an issue to follow up on adding wasm tests to CI, so we don't forget it.

shssoichiro avatar Mar 12 '24 01:03 shssoichiro

On second thought, maybe add a comment in the Cargo.toml that clap is held back for MSRV reasons?

FreezyLemon avatar Mar 15 '24 18:03 FreezyLemon

It should be freshened and landed... Somehow the notification got lost.

lu-zero avatar Aug 14 '24 11:08 lu-zero

Meh, let's bump to 1.74 and be done with that :)

lu-zero avatar Aug 14 '24 16:08 lu-zero