appstream icon indicating copy to clipboard operation
appstream copied to clipboard

Screenshot environment

Open CarlSchwan opened this issue 1 year ago • 1 comments

In https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-screenshots

there is an example with environment="plasma-mobile"

  <screenshot environment="plasma-mobile">
    <caption>The FooBar main window, but on Plasma Mobile</caption>
    <image type="source" width="1600" height="900">https://example.com/foobar/screenshot-1_plasma-mobile.png</image>
  </screenshot>

but unfortunately plasma-mobile is not in the authorized styles: https://github.com/ximion/appstream/blob/main/data/desktop-style-ids.txt

CarlSchwan avatar Feb 29 '24 09:02 CarlSchwan

Yes. So, is this a request to add it to the available styles, or to change the example? ;-)

ximion avatar Mar 02 '24 18:03 ximion

Yes. So, is this a request to add it to the available styles, or to change the example? ;-)

I just stumbled across the vary same issue. I would propose to add plasma-mobile as an environment. Screenshots of the mobile appearance of an application might be very different from what they would look on plasma, so in my opinion it makes sense to add it. Let me know, if you can use a little PR for that :)

1Maxnet1 avatar Mar 26 '24 08:03 1Maxnet1

A PR would be welcome (see desktop-style-ids.txt). I guess the "mobile" is not a style, so it should indeed be plasma-mobile and not plasma:mobile (which would also allow plasma-mobile:dark later, I guess).

ximion avatar Mar 26 '24 10:03 ximion

This can be closed

razzeee avatar Apr 07 '24 14:04 razzeee

Indeed!

ximion avatar Apr 07 '24 15:04 ximion