firefox-scripts icon indicating copy to clipboard operation
firefox-scripts copied to clipboard

Nightly (2023-02-22) breaks DownThemAll interaface

Open jiangzhenjerry opened this issue 2 years ago • 15 comments

Today (2/22/2023) Firefox Nightly breaks the interface of DownThemAll again. It looks funny (but still functional!)

sshot-1

jiangzhenjerry avatar Feb 22 '23 18:02 jiangzhenjerry

OK things are getting worse today... I cannot see the window control (min/max/close) anymore...

2023-02-23_160531

jiangzhenjerry avatar Feb 24 '23 00:02 jiangzhenjerry

They also broke the Password Manager interface again, it's like the fourth time in the last six months.

marty60 avatar Mar 14 '23 15:03 marty60

Same issues with DTA with FF update 112.

TimidScript avatar Apr 12 '23 13:04 TimidScript

moz-image-region removed in bug from ff code, but not removed from HTML5 DownThemAll-3.1.2.112.2023.04.22-xiao.xpi.zip

dimdamin avatar Apr 25 '23 10:04 dimdamin

@dimdamin Thanks for the fix! Appreciated.

jiangzhenjerry avatar Apr 25 '23 16:04 jiangzhenjerry

moz-image-region removed in bug from ff code, but not removed from HTML5 DownThemAll-3.1.2.112.2023.04.22-xiao.xpi.zip

Anyone else having issues resizing columns in the download manager? Some of the columns refuse to shrink and it's pushing the scrollbar out of the window.

Small missed icon, I think: image

Overall great fix, thanks.

jathek avatar Apr 25 '23 17:04 jathek

Anyone else having issues resizing columns in the download manager? Some of the columns refuse to shrink and it's pushing the scrollbar out of the window.

Yeah... I'm also observing squeezed columns that cannot be expanded.

sshot-1

jiangzhenjerry avatar Apr 25 '23 17:04 jiangzhenjerry

Not only moz-image-region got removed, also multiple other moz-box-* CSS properties will be removed in v113 which will break the preferences panel completly. My try on fixing it takes a different route with handling the moz-image-region by splitting the PNG images in multiple files, but the result is the same working extension. Also the mentioned moz-box properties are handled (but only on win, mac und unix are not fixed and not tested). dta.xpi.zip

xelsios avatar Apr 25 '23 18:04 xelsios

@xelsios Good change, thank you. Looks like it was annoying to do.

-- Edit -- It looks like something is glitched out. At some point the Make Your Selection window ends up being truncated like the folks above.

image

TFWol avatar Apr 29 '23 16:04 TFWol

I updated the interface in DownThemAll and S3Download, works for me... Maybe it will be works for you to, tested at 102 and 113 DownThemAll-3.1.2.112.2023.05.10-xiao.xpi.zip s3download-4.14.109.2023.05.10-xiao.xpi.zip

dimdamin avatar May 11 '23 06:05 dimdamin

Thanks all for the DTA interface fix, that was nasty. I also saw where the columns in the DownThemAll interface were fixed in select.xhtml with flex-grow:. I was able to apply that to password manager with success.

marty60 avatar May 12 '23 21:05 marty60

Thanks @xelsios and @dimdamin for the fixes. Wanted to give all the DTA fans an update that DTA is completely dead under 115a1 starting 2023/05/13. I initiated a new bug report #259 to track. Hope there will be a fix eventually.

jiangzhenjerry avatar May 14 '23 21:05 jiangzhenjerry

I'm worried about @xiaoxiaoflood ; no activity on github for a couple of months.

TFWol avatar May 15 '23 17:05 TFWol

I'm worried about @xiaoxiaoflood ; no activity on github for a couple of months.

He's around, I think he posts at Reddit as tustamido and there's new ones today.

https://old.reddit.com/r/XUL_for_Quantum_Dev/comments/fs76ff/little_update_current_fx_version_75/

marty60 avatar May 15 '23 18:05 marty60

I'm worried about @xiaoxiaoflood ; no activity on github for a couple of months.

He's around, I think he posts at Reddit as tustamido and there's new ones today.

https://old.reddit.com/r/XUL_for_Quantum_Dev/comments/fs76ff/little_update_current_fx_version_75/

Ah good, thanks for the info; I've had a lot of developers I liked disappear lately

TFWol avatar May 15 '23 18:05 TFWol