SortingLab.jl icon indicating copy to clipboard operation
SortingLab.jl copied to clipboard

Published 20 hours ago • verified publisher icon xiaodaigh

Allow AbstractVectors

Open ParadaCarleton opened this issue 4 years ago • 3 comments

Replaces Vector with AbstractVector in some type annotations, so these methods can be used more broadly.

ParadaCarleton avatar Jul 19 '21 21:07 ParadaCarleton

Have to be careful here as SortingLab makes assumptions about vector's memory layout sometimes.

I also haven't turned on CI testing, so need to check if tests pass offline.

xiaodaigh avatar Jul 19 '21 22:07 xiaodaigh

@xiaodaigh makes sense; worth noting the tests are all working on my end.

ParadaCarleton avatar Jul 20 '21 01:07 ParadaCarleton

need to check if there are missing tests.

Are you able to add some tests for non-vector input and see if they work?

xiaodaigh avatar Jul 20 '21 03:07 xiaodaigh