packer-plugin-xenserver icon indicating copy to clipboard operation
packer-plugin-xenserver copied to clipboard

Added fix for build failing due to missing go-vnc

Open dongyuzheng opened this issue 9 years ago • 8 comments

Fix for:

dzheng@dzheng-ubuntu-desktop:~/go/src/github.com/xenserver/packer-builder-xenserver$ ./build.sh 
==> Removing old directory...
Number of parallel builds: 7

-->     linux/amd64: github.com/xenserver/packer-builder-xenserver/plugin/builder-xenserver-xva
-->     linux/amd64: github.com/xenserver/packer-builder-xenserver/plugin/builder-xenserver-iso

2 errors occurred:
--> linux/amd64 error: exit status 1
Stderr: builder/xenserver/common/step_type_boot_command.go:7:2: cannot find package "github.com/mitchellh/go-vnc" in any of:
    /home/dzheng/go/src/github.com/xenserver/packer-builder-xenserver/vendor/github.com/mitchellh/go-vnc (vendor tree)
    /usr/local/go/src/github.com/mitchellh/go-vnc (from $GOROOT)
    /home/dzheng/go/src/github.com/mitchellh/go-vnc (from $GOPATH)

--> linux/amd64 error: exit status 1
Stderr: builder/xenserver/common/step_type_boot_command.go:7:2: cannot find package "github.com/mitchellh/go-vnc" in any of:
    /home/dzheng/go/src/github.com/xenserver/packer-builder-xenserver/vendor/github.com/mitchellh/go-vnc (vendor tree)
    /usr/local/go/src/github.com/mitchellh/go-vnc (from $GOROOT)
    /home/dzheng/go/src/github.com/mitchellh/go-vnc (from $GOPATH)

dongyuzheng avatar Oct 26 '16 18:10 dongyuzheng

Does this fix the problem of using xenserver with packer 1.0?

timoc avatar Jul 04 '17 21:07 timoc

I'm not sure what you're referring to. Please be more specific with your problem.

dongyuzheng avatar Jul 04 '17 21:07 dongyuzheng

I've been trying to use packer xen plugin with the packer 1.0 builds without success. not being much of go person i'm having trouble with it. thought this might fix it.

timoc avatar Jul 14 '17 19:07 timoc

Hello, A merge would be welcome because this fix (#60) solve my issue with go-vnc missing.

Vagrantin avatar Jun 13 '20 15:06 Vagrantin

Hi @Vagrantin , please try this fork instead: https://github.com/ctlam/packer-builder-xenserver

dongyuzheng avatar Jun 13 '20 21:06 dongyuzheng

Hi @Vagrantin , please try this fork instead: https://github.com/ctlam/packer-builder-xenserver

Thanks, what is the goal of this fork, you mean this current repo is not maintained anymore ?

Vagrantin avatar Jun 17 '20 06:06 Vagrantin

Please review for merge.

timoc avatar Jun 27 '20 11:06 timoc

what is the goal of this fork

Hi @Vagrantin, I was at NVIDIA back in 2016 and we needed some new features / bug fixes to this repo. At the time, I made many Pull Requests, which remain unaddressed to this day.

If you look at the fork history, you'd see that

https://github.com/NVIDIA/packer-builder-xenserver --> comes from https://github.com/ctlam/packer-builder-xenserver --> comes from https://github.com/iyyuan/packer-builder-xenserver --> from my repo https://github.com/dongyuzheng/packer-builder-xenserver --> from this repo https://github.com/xenserver/packer-builder-xenserver

But https://github.com/ctlam/packer-builder-xenserver is the one most ahead right now, so that is the one I'd recommend.

dongyuzheng avatar Jun 28 '20 08:06 dongyuzheng