bpf-examples icon indicating copy to clipboard operation
bpf-examples copied to clipboard

Consolidate duplicate tc-loader scripts

Open tohojo opened this issue 4 years ago • 5 comments

We should probably consolidate the different copies of the TC loader scripts in subdirectories into a single version in a parent/lib directory...

tohojo avatar Jan 26 '21 19:01 tohojo

Same thing probably goes for the configure script to detect if iproute has libbpf support.

simosund avatar Feb 08 '21 10:02 simosund

Yeah. IIRC, @netoptimizer expressed a preference for keeping separate configure scripts in each subdir, but they can still share code :)

tohojo avatar Feb 08 '21 14:02 tohojo

Worth mentioning that in my current PR I've extended the tc loader script somewhat to support attaching a pinned program (and gotten rid of the configure script).

simosund avatar Mar 15 '21 09:03 simosund

As libbpf now support TC-attaching directly, we should consider converting "pping" and "traffic-pacing-edt" to use that instead of mentioned shell script.

netoptimizer avatar Jun 03 '21 09:06 netoptimizer

Yep, converting pping to use libbpf for attaching the tc program is on my TODO list, so this issue is likely goning to resolve itself that way.

simosund avatar Jun 03 '21 10:06 simosund