twitter-ruby-ads-sdk icon indicating copy to clipboard operation
twitter-ruby-ads-sdk copied to clipboard

Adds Video and Image diemensions field in respective class

Open himanshu-patel-dev opened this issue 1 year ago • 1 comments

Both classes ImageConversationCard and VideoConversationCard have field which have data related to dimensions/size of Video/Image but these fields despite present in API are being dropped/ignored in class properties/attributes, thus consumer of this library can't assess data like 'image_display_height' on ImageConversationCard till now. Current fix enable the same for both Image and Video Conversation Card.

Issue Type: Improvement

Fixes / Relates To: #273

Changes Included:

  • Adding two properties image_display_height and image_display_width in ImageConversationCard class
  • Adding two properties video_width and video_height in VideoConversationCard class

himanshu-patel-dev avatar Oct 26 '24 18:10 himanshu-patel-dev

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 26 '24 18:10 CLAassistant

Can maintainers of the librarary provide approval for remaining workflows to trigger. @tushdante

himanshu-patel-dev avatar Nov 19 '24 12:11 himanshu-patel-dev