vscode-php-debug icon indicating copy to clipboard operation
vscode-php-debug copied to clipboard

README updates for Docker

Open jasonterando opened this issue 8 years ago β€’ 10 comments

Information on getting Visual Code + PHP Debug extension working with PHP running in Docker. It may be worth including in your docs. Thanks for the great extension!

jasonterando avatar Feb 20 '17 19:02 jasonterando

Not on purpose, but very possibly. Let me see if I can de-fubar it...

jasonterando avatar Jun 22 '17 19:06 jasonterando

@jasonterando Thanks for the updates here. Even though the PR hasn't been accepted your steps for Windows XDEBUG configuration worked perfectly for me.

seangwright avatar Jul 18 '17 04:07 seangwright

@sgwatgit - awesome, glad to help!

jasonterando avatar Jul 18 '17 12:07 jasonterando

This also needs to be updated to reflect the changes for the new pathmappings setting.

cardonator avatar Nov 25 '17 07:11 cardonator

Codecov Report

Merging #144 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #144   +/-   ##
=======================================
  Coverage   80.18%   80.18%           
=======================================
  Files           2        2           
  Lines         111      111           
  Branches       22       22           
=======================================
  Hits           89       89           
  Misses         14       14           
  Partials        8        8

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update bfeea18...c65725e. Read the comment docs.

codecov[bot] avatar Nov 25 '17 15:11 codecov[bot]

I didn't realize anybody was still looking at this. I've updated to include pathMappings and the built-in Docker localhost aliases.

jasonterando avatar Nov 25 '17 15:11 jasonterando

@jasonterando I think you committed a bad merge

felixfbecker avatar Nov 25 '17 19:11 felixfbecker

Did a re-merge with master and the CI/CD checks seem to be happier

jasonterando avatar Nov 27 '17 17:11 jasonterando

@jasonterando please look at the file on your branch. It was messed up: https://github.com/jasonterando/vscode-php-debug/blob/c65725e1bd5fcea4034c12776f967af2ccb312e3/README.md

felixfbecker avatar Nov 27 '17 17:11 felixfbecker

Too bad this isn't merged yet, very helpful additional info! πŸ‘

smxsm avatar Mar 15 '18 21:03 smxsm