xcat-core
xcat-core copied to clipboard
error message for mkdef - can't make a node with that name because there is already a group with that name
Summary
was lost for a few hours because of bad error message. made me so frustrated i wanted to quit my job today.
Actual Error Seen
[root@c650mnp05 yum.repos.d]# mkdef -t node -o c650f99p12 groups=all Error: [c650mnp05]: No object names were provided
Expected behavior and suggestions
make the error message clearer
i think the real issue was that there was a group that already existed with this name. please update the error message to say something like "yo i can't make a node with that name because there is already a group with that name"
or if you already have an error path for that, then make sure it is being triggered correctly, or why this "no object name" is being triggered incorrectly.
then add in a test case to check and make sure this works. that way in case future code updates break this functionality, we have a early heads up . (because maybe that is what happen here)