repo-plugins icon indicating copy to clipboard operation
repo-plugins copied to clipboard

Published 20 hours ago • verified publisher icon xbmc

[plugin.video.catchuptvandmore@krypton] 0.2.38

Open joaopa00 opened this issue 3 years ago • 6 comments

  • [x] My code follows the add-on rules and piracy stance of this project.
  • [x] I have read the CONTRIBUTING document
  • [x] Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Once more, this PR is pretty huge. If this PR is merged very quickly, I will send the newest version very soon. So, the PR for the next coming version 0.2.39 should be relatively small, so easier to review.

Thanks for your understanding.

joaopa00 avatar Oct 02 '22 04:10 joaopa00

What means the error in Kodi addon-checker?

joaopa00 avatar Oct 02 '22 04:10 joaopa00

Means you need higher versions in matrix and nexus for users with this version installed in krypton to be able to receive the update when migrating to an up to date Kodi version. If you already have those updates pending (for matrix and nexus) ignore the message, ci will pass once the other two prs are merged.

enen92 avatar Oct 02 '22 08:10 enen92

I see. Since I already sent the version the version for matrix, there is no problem I think. Can you confirm?

joaopa00 avatar Oct 02 '22 16:10 joaopa00

I removed the problematic feature. Thank you for the review and the feedback.

(Not so) unrelated note: I pushed some logos and picture in the repository repo-resources. Can you merge them?

joaopa00 avatar Oct 05 '22 19:10 joaopa00

I removed the problematic feature. Thank you for the review and the feedback.

(Not so) unrelated note: I pushed some logos and picture in the repository repo-resources. Can you merge them?

joaopa00 avatar Oct 06 '22 00:10 joaopa00

I sent a PR to repo-scripts to merge enum34. Once that's done, I shall update this PR to take advantage of this feature.

joaopa00 avatar Oct 11 '22 09:10 joaopa00

I removed the dependency on Enum. Please, have a look at this new version

joaopa00 avatar Oct 22 '22 15:10 joaopa00

I modified this PR following the recommendations from the Matrix PR versions. Please have a look.

joaopa00 avatar Dec 11 '22 19:12 joaopa00

I will double check it.

basrieter avatar Dec 11 '22 20:12 basrieter

Any news for this PR will be welcome. Thanks in advance for any feedback

joaopa00 avatar Jan 27 '23 16:01 joaopa00

Is there anything more I should do to make this pull request merged?

joaopa00 avatar Feb 14 '23 12:02 joaopa00

@joaopa00 check addon checker log, looks like you have some incorrectly closed ")" somewhere. Might check the execution locally to see where that is exactly triggered

enen92 avatar Feb 15 '23 11:02 enen92

@pkscout @enen92, sorry to bother you, but the status of this PR is not really clear to me. Are there blocking points remaining? Any chance to see this merged soon?

connesc avatar Mar 02 '23 23:03 connesc

Yes, pull request is completely broken...

enen92 avatar Mar 03 '23 15:03 enen92

How can I know where is the problem with local kodi-addon-checker?

$ kodi-addon-checker --branch krypton --enable-debug-log INFO: Checking add-on plugin.video.catchuptvandmore INFO: Created by SylvainCecchetto,wwark,joaopa INFO: Addon id matches folder name INFO: Valid XML file found INFO: Image icon exists INFO: icon dimensions are fine 512x512 INFO: Image fanart exists INFO: fanart dimensions are fine 1280x720 INFO: fanart file size is fine 690KB INFO: Image screenshot exists INFO: screenshot dimensions are fine 1920x1080 INFO: screenshot file size is fine 124KB INFO: Image screenshot exists INFO: screenshot dimensions are fine 1920x1080 INFO: screenshot file size is fine 452KB INFO: Image screenshot exists INFO: screenshot dimensions are fine 1920x1080 INFO: screenshot file size is fine 114KB INFO: Image screenshot exists INFO: screenshot dimensions are fine 1920x1080 INFO: screenshot file size is fine 339KB INFO: Image screenshot exists INFO: screenshot dimensions are fine 1920x1080 INFO: screenshot file size is fine 229KB ERROR: ParseError: bad input: type=8, value=')', context=('', (332, 48)) INFO: ParseError: bad input: type=8, value=')', context=('', (332, 48)) INFO: PO files are valid WARN: Found non whitelisted file ending in filename ./plugin.video.catchuptvandmore/kodi-addon-checker.log ERROR: We found 1 problems and 1 warnings, please check the logfile.

joaopa00 avatar Mar 04 '23 23:03 joaopa00

That means you have a syntax error in your python code some parenthesis that don't have a matching close tag. I can't really tell where it is with that log though. Also please drop any github actions file from the submission

enen92 avatar Mar 05 '23 11:03 enen92

Fortunately, pylint is better than kodi-addon-checker to explicit syntax errors. I also fixed the problem you pinpointed about github action.

joaopa00 avatar Mar 05 '23 15:03 joaopa00 

File "/opt/hostedtoolcache/Python/3.11.2/x64/lib/python3.11/lib2to3/pgen2/driver.py", line 47, in parse_tokens
    for quintuple in tokens:
  File "/opt/hostedtoolcache/Python/3.11.2/x64/lib/python3.11/lib2to3/pgen2/tokenize.py", line 424, in generate_tokens
    raise IndentationError(
  File "<tokenize>", line 2[38](https://github.com/xbmc/repo-plugins/actions/runs/4336770275/jobs/7572297642#step:6:39)
    yield item
IndentationError: unindent does not match any outer indentation level

enen92 avatar Mar 05 '23 15:03 enen92

Thanks. I fixed this problem too.

joaopa00 avatar Mar 05 '23 15:03 joaopa00

Thank you for merging this PR. Sorry for the trouble. Is it possible to merge the pictures from repo-ressource?

joaopa00 avatar Mar 05 '23 16:03 joaopa00