repo-plugins icon indicating copy to clipboard operation
repo-plugins copied to clipboard

Published 20 hours ago • verified publisher icon xbmc

[plugin.program.rtorrent] 19.21.10

Open djcode opened this issue 4 years ago • 4 comments

Description

A simple plugin for interacting with an rTorrent instance.

Checklist:

  • [X] My code follows the add-on rules and piracy stance of this project.
  • [X] I have read the CONTRIBUTING document
  • [X] Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practice but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.
  • If you see no activity on your PR after a week (so at least one weekend has passed) then please go to the #kodi-dev freenode IRC channel to reach out to the team

djcode avatar Oct 12 '21 00:10 djcode

@enen92 Is there anything else I need to do to have this plugin merged in?

djcode avatar Dec 22 '21 19:12 djcode

Someone to actually review the code, I haven't looked yet.

enen92 avatar Dec 22 '21 19:12 enen92

ping @djcode

enen92 avatar May 15 '22 16:05 enen92

Thanks @enen92. I missed the notification that this had been looked at.

Trying to wrap my head on how I can accomplish the requested changes. I'm calculating the file path and availability on playback and if I'm missing something obvious, the listitem object would not be available to me at that point. For example, If the file is not completely downloaded, I issue a confirmation if the user is sure they want to play it. In the past, end users trying to play incomplete files has caused Kodi to lock up, so I figure the warning is needed.

Can I pass a listitem object between RunPlugin calls?

djcode avatar May 17 '22 01:05 djcode

Closing as stalled, please resubmit if still interested

enen92 avatar Aug 29 '22 13:08 enen92