xamarin-macios icon indicating copy to clipboard operation
xamarin-macios copied to clipboard

[Rgen] Implement SmartEnums code emittion.

Open mandel-macaque opened this issue 1 year ago • 25 comments

This change brings the following:

  1. We now generate the Extension classes for the SmartEnums.
  2. Bumped the roslyn version, the one we were using had a bug when using dir separators in the name hint for a generated file.
  3. Generated code is added under the expected directory for bgen to allow the API diff.

PS: Create as a draft because it depends on a previous PR but I want to see that the generated diff is correct.

mandel-macaque avatar Oct 17 '24 12:10 mandel-macaque

:warning: Your code has been reformatted. :warning:

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

github-actions[bot] avatar Oct 17 '24 13:10 github-actions[bot]

:computer: [CI Build] Windows Integration Tests passed :computer:

:white_check_mark: All Windows Integration Tests passed.

Pipeline on Agent Hash: 0f10657df9976b590f639ebd51e0064cbd7d41fb [PR build]

:white_check_mark: API diff for current PR / commit

.NET (No breaking changes)

:white_check_mark: API diff vs stable

.NET (No breaking changes)

:information_source: Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent Hash: 0f10657df9976b590f639ebd51e0064cbd7d41fb [PR build]

:computer: [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed :computer:

:white_check_mark: All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent Hash: 0f10657df9976b590f639ebd51e0064cbd7d41fb [PR build]

:x: [CI Build] Tests on macOS M1 - Mac Monterey (12) failed :x:

Failed tests are:

  • introspection

Pipeline on Agent Hash: 0f10657df9976b590f639ebd51e0064cbd7d41fb [PR build]

:x: [CI Build] Tests on macOS M1 - Mac Ventura (13) failed :x:

Failed tests are:

  • introspection

Pipeline on Agent Hash: 0f10657df9976b590f639ebd51e0064cbd7d41fb [PR build]

:fire: [CI Build] Test results :fire:

Test results

:x: Tests failed on VSTS: test results

0 tests crashed, 3 tests failed, 98 tests passed.

Failures

:x: cecil tests

1 tests failed, 0 tests passed.
  • Cecil-based tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

:x: dotnettests tests (tvOS)

1 tests failed, 0 tests passed.
  • DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

:x: monotouch tests (macOS)

1 tests failed, 8 tests passed.
  • monotouch-test/Mac [dotnet]/Release (static registrar, all optimizations) [dotnet]: TimedOut (Execution timed out after 1200 seconds. Test run crashed)

Html Report (VSDrops) Download

Successes

:white_check_mark: dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: framework: All 2 tests passed. Html Report (VSDrops) Download :white_check_mark: fsharp: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: generator: All 3 tests passed. Html Report (VSDrops) Download :white_check_mark: interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: introspection: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: linker: All 40 tests passed. Html Report (VSDrops) Download :white_check_mark: monotouch (iOS): All 7 tests passed. Html Report (VSDrops) Download :white_check_mark: monotouch (MacCatalyst): All 8 tests passed. Html Report (VSDrops) Download :white_check_mark: monotouch (tvOS): All 7 tests passed. Html Report (VSDrops) Download :white_check_mark: msbuild: All 2 tests passed. Html Report (VSDrops) Download :white_check_mark: xcframework: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent Hash: 0f10657df9976b590f639ebd51e0064cbd7d41fb [PR build]

:warning: Your code has been reformatted. :warning:

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

github-actions[bot] avatar Oct 17 '24 19:10 github-actions[bot]

:computer: [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed :computer:

:white_check_mark: All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent Hash: d836caf2a7e41e0ca9d2fd979d02cff06f091a71 [PR build]

:x: [CI Build] Tests on macOS M1 - Mac Monterey (12) failed :x:

Failed tests are:

  • introspection

Pipeline on Agent Hash: d836caf2a7e41e0ca9d2fd979d02cff06f091a71 [PR build]

:x: [CI Build] Tests on macOS M1 - Mac Ventura (13) failed :x:

Failed tests are:

  • introspection

Pipeline on Agent Hash: d836caf2a7e41e0ca9d2fd979d02cff06f091a71 [PR build]

:computer: [CI Build] Windows Integration Tests passed :computer:

:white_check_mark: All Windows Integration Tests passed.

Pipeline on Agent Hash: d836caf2a7e41e0ca9d2fd979d02cff06f091a71 [PR build]

:white_check_mark: API diff for current PR / commit

.NET (No breaking changes)

:white_check_mark: API diff vs stable

.NET (No breaking changes)

:information_source: Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent Hash: d836caf2a7e41e0ca9d2fd979d02cff06f091a71 [PR build]

:fire: [CI Build] Test results :fire:

Test results

:x: Tests failed on VSTS: test results

0 tests crashed, 2 tests failed, 99 tests passed.

Failures

:x: cecil tests

1 tests failed, 0 tests passed.
  • Cecil-based tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

:x: dotnettests tests (MacCatalyst)

1 tests failed, 0 tests passed.
  • DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

Successes

:white_check_mark: dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: framework: All 2 tests passed. Html Report (VSDrops) Download :white_check_mark: fsharp: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: generator: All 3 tests passed. Html Report (VSDrops) Download :white_check_mark: interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: introspection: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: linker: All 40 tests passed. Html Report (VSDrops) Download :white_check_mark: monotouch (iOS): All 7 tests passed. Html Report (VSDrops) Download :white_check_mark: monotouch (MacCatalyst): All 8 tests passed. Html Report (VSDrops) Download :white_check_mark: monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download :white_check_mark: monotouch (tvOS): All 7 tests passed. Html Report (VSDrops) Download :white_check_mark: msbuild: All 2 tests passed. Html Report (VSDrops) Download :white_check_mark: xcframework: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent Hash: d836caf2a7e41e0ca9d2fd979d02cff06f091a71 [PR build]

:warning: Your code has been reformatted. :warning:

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

github-actions[bot] avatar Oct 18 '24 17:10 github-actions[bot]

:warning: Your code has been reformatted. :warning:

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

github-actions[bot] avatar Oct 18 '24 18:10 github-actions[bot]

:fire: [CI Build] Build failed :fire:

Build failed for the job 'Detect API changes'

Pipeline on Agent Hash: 5d5d67e5807ac82caa323fa26434722ce2387641 [PR build]

:fire: [CI Build] Build failed :fire:

Build failed for the job 'Build packages'

Pipeline on Agent Hash: 5d5d67e5807ac82caa323fa26434722ce2387641 [PR build]

:fire: [CI Build] Build failed :fire:

Build failed for the job 'Build macOS tests'

Pipeline on Agent Hash: 5d5d67e5807ac82caa323fa26434722ce2387641 [PR build]

:warning: Your code has been reformatted. :warning:

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

github-actions[bot] avatar Oct 18 '24 20:10 github-actions[bot]

:warning: Your code has been reformatted. :warning:

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

github-actions[bot] avatar Oct 18 '24 20:10 github-actions[bot]

:fire: [CI Build] Build failed :fire:

Build failed for the job 'Build macOS tests'

Pipeline on Agent Hash: 474b05429e6276dd41bd36d55fdf0a5aae1ad0ae [PR build]

:fire: [CI Build] Build failed :fire:

Build failed for the job 'Detect API changes'

Pipeline on Agent Hash: 4a07007e798638ae925e7c00d906a71da068c89f [PR build]

:fire: [CI Build] Build failed :fire:

Build failed for the job 'Build packages'

Pipeline on Agent Hash: 4a07007e798638ae925e7c00d906a71da068c89f [PR build]

:fire: [CI Build] Build failed :fire:

Build failed for the job 'Build macOS tests'

Pipeline on Agent Hash: 4a07007e798638ae925e7c00d906a71da068c89f [PR build]

:warning: Your code has been reformatted. :warning:

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

github-actions[bot] avatar Oct 21 '24 02:10 github-actions[bot]

:fire: [CI Build] Build failed :fire:

Build failed for the job 'Detect API changes'

Pipeline on Agent Hash: f11bb1b036b8b248da527c94390abe34c00254c5 [PR build]

:fire: [CI Build] Build failed :fire:

Build failed for the job 'Build macOS tests'

Pipeline on Agent Hash: f11bb1b036b8b248da527c94390abe34c00254c5 [PR build]

:fire: [CI Build] Build failed :fire:

Build failed for the job 'Build packages'

Pipeline on Agent Hash: f11bb1b036b8b248da527c94390abe34c00254c5 [PR build]

:warning: Your code has been reformatted. :warning:

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

github-actions[bot] avatar Oct 21 '24 18:10 github-actions[bot]